Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12452 )
Change subject: IMPALA-8186: script to configure docker network ...................................................................... Patch Set 2: (8 comments) Thanks for the comments. We really need some kind of automated testing to flush out issues with this. I've been iterating on that in parallel - https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/14 http://gerrit.cloudera.org:8080/#/c/12452/2/docker/configure_test_network.sh File docker/configure_test_network.sh: http://gerrit.cloudera.org:8080/#/c/12452/2/docker/configure_test_network.sh@23 PS2, Line 23: # cluster configurations need to be regenerated, all minicluster processes restarted, > nit, extra space. Done http://gerrit.cloudera.org:8080/#/c/12452/2/docker/configure_test_network.sh@43 PS2, Line 43: Create creating > Nit: extra word Done http://gerrit.cloudera.org:8080/#/c/12452/2/docker/configure_test_network.sh@43 PS2, Line 43: Create creating > Nit: extra word Done http://gerrit.cloudera.org:8080/#/c/12452/2/docker/configure_test_network.sh@44 PS2, Line 44: impala-cluster > I think this should be $NETWORK_NAME ? Done http://gerrit.cloudera.org:8080/#/c/12452/2/docker/configure_test_network.sh@44 PS2, Line 44: impala-cluster > I think this should be $NETWORK_NAME ? Done http://gerrit.cloudera.org:8080/#/c/12452/2/docker/configure_test_network.sh@45 PS2, Line 45: GATEWAY=$(docker network inspect "$NETWORK_NAME" | grep -o '"Gateway": "[0-9\.]*"' | \ : grep -o "[0-9.]*") > I don't know if the following makes you any happier: Much nicer http://gerrit.cloudera.org:8080/#/c/12452/2/docker/configure_test_network.sh@50 PS2, Line 50: echo "export INTERNAL_LISTEN_HOST=${GATEWAY}" >> bin/impala-config-local.sh > This clearly persists across restarts. Does the "docker network create" com Yeah they are persistent (tested on my laptop). The gateway and subnet seem to be stable. There's an issue I'm punting on here which the IP range allocated by docker conflicting with your internal network. My version of docker allocates 17.x.0.0/16, incrementing x each time. There isn't an obvious general solution to me since it depends on where you're running. http://gerrit.cloudera.org:8080/#/c/12452/2/docker/configure_test_network.sh@50 PS2, Line 50: echo "export INTERNAL_LISTEN_HOST=${GATEWAY}" >> bin/impala-config-local.sh : echo "export DEFAULT_FS=hdfs://\${INTERNAL_LISTEN_HOST}:20500" \ : >> bin/impala-config-local.sh > Nit: Can we also add an accompanying comment to bin/impala-config-local.sh Done -- To view, visit http://gerrit.cloudera.org:8080/12452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb4854aa951bcad7087a9653845b22ffd862057d Gerrit-Change-Number: 12452 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 12 Feb 2019 20:05:45 +0000 Gerrit-HasComments: Yes
