Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12452 )
Change subject: IMPALA-8186: script to configure docker network ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Thanks. Happy to chat with you about test-with-docker and whether it makes sense to shove this in there too. There are pros and cons... http://gerrit.cloudera.org:8080/#/c/12452/2/docker/configure_test_network.sh File docker/configure_test_network.sh: http://gerrit.cloudera.org:8080/#/c/12452/2/docker/configure_test_network.sh@50 PS2, Line 50: >> "$IMPALA_HOME"/bin/impala-config-local.sh > Yeah they are persistent (tested on my laptop). The gateway and subnet seem There's some sort of "--bip" flag that I've used to make Docker not knock me off my network. https://docs.docker.com/v17.09/engine/userguide/networking/default_network/custom-docker0/ Not sure if it applies here; I've not tried what you're doing. -- To view, visit http://gerrit.cloudera.org:8080/12452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb4854aa951bcad7087a9653845b22ffd862057d Gerrit-Change-Number: 12452 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 12 Feb 2019 20:17:18 +0000 Gerrit-HasComments: Yes
