Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13259 )
Change subject: Improve output for generate-schema-statements.py ...................................................................... Patch Set 1: Code-Review+1 (2 comments) LGTM, I'm not sure if there are any tools that depend on the original output, so that's why I only gave it +1. http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py File testdata/bin/generate-schema-statements.py: http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py@538 PS1, Line 538: class LogOutput(object): nit: maybe TabularLogOutput or something more verbose? http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py@622 PS1, Line 622: \' nit: use " for the whole string just like in L616? -- To view, visit http://gerrit.cloudera.org:8080/13259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf53fde209bb7ee319a4c13667f3fa2783507072 Gerrit-Change-Number: 13259 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 07 May 2019 14:15:28 +0000 Gerrit-HasComments: Yes
