Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13259 )
Change subject: Improve output for generate-schema-statements.py ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py File testdata/bin/generate-schema-statements.py: http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py@809 PS1, Line 809: {} Python 2.6 doesn't support {}. It needs to be {0}. http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py@861 PS1, Line 861: out_status.dump() What do you think about dumping this to a file rather than stdout? I think it would be more useful for it to go to a file alongside all the SQL files. I personally don't feel like this output is useful to a developer running these things from the console. -- To view, visit http://gerrit.cloudera.org:8080/13259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf53fde209bb7ee319a4c13667f3fa2783507072 Gerrit-Change-Number: 13259 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 07 May 2019 17:50:27 +0000 Gerrit-HasComments: Yes
