Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13259 )
Change subject: Improve output for generate-schema-statements.py ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py File testdata/bin/generate-schema-statements.py: http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py@538 PS1, Line 538: def _get_component_version(name): > nit: maybe TabularLogOutput or something more verbose? Done http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py@622 PS1, Line 622: es > nit: use " for the whole string just like in L616? Done http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py@809 PS1, Line 809: ba > I'm still working on it :). I've only done the toolchain-side change so far Done http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py@861 PS1, Line 861: if insert > I was about to comment something about using the --verbose flag, but then I How about deferring this change to later? Want to make a quick incremental improvement here and not scope creep to also creating new log files, etc. -- To view, visit http://gerrit.cloudera.org:8080/13259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf53fde209bb7ee319a4c13667f3fa2783507072 Gerrit-Change-Number: 13259 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 13 May 2019 23:31:20 +0000 Gerrit-HasComments: Yes
