Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13259 )
Change subject: Improve output for generate-schema-statements.py ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py File testdata/bin/generate-schema-statements.py: http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py@861 PS1, Line 861: out_status.dump() > What do you think about dumping this to a file rather than stdout? I think hm, I actually went down this path because I was trying to understand why different sets of tables were being selected during a data load. I think when you are running 'buildall.sh' this already gets piped to a file, no? It's only if you are explicitly calling load-data.py in which case I think the output's nice. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/13259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf53fde209bb7ee319a4c13667f3fa2783507072 Gerrit-Change-Number: 13259 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 07 May 2019 18:27:23 +0000 Gerrit-HasComments: Yes
