Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13333 )
Change subject: IMPALA-6903: Download profile from WebUI in text format ...................................................................... Patch Set 1: (1 comment) I would like to have a better test, but do not know how to. http://gerrit.cloudera.org:8080/#/c/13333/1/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/13333/1/tests/webserver/test_web_pages.py@555 PS1, Line 555: assert len(responses) == 1 > should we have more assert instead of just asserting the len? The href is dynamic, I can not find a way to get real download link for the file in the html page, so can not verify more than that. In the page, it is initial value (javascript:void(0)) Any idea on how to get the real link with the response? -- To view, visit http://gerrit.cloudera.org:8080/13333 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie030c2bb330211f51840417b9f7880f19174af7b Gerrit-Change-Number: 13333 Gerrit-PatchSet: 1 Gerrit-Owner: Yongzhi Chen <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Yongzhi Chen <[email protected]> Gerrit-Comment-Date: Tue, 14 May 2019 23:53:03 +0000 Gerrit-HasComments: Yes
