Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13333 )
Change subject: IMPALA-6903: Download profile from WebUI in text format ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13333/1/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/13333/1/tests/webserver/test_web_pages.py@555 PS1, Line 555: assert len(responses) == 1 > The href is dynamic, I can not find a way to get real download link for the I'm no Javascript expert, so if this approach is getting too complex. I think it might be better just to duplicate what we do for the "query_profile_encoded". The advantage of your current approach is that you save requesting the runtime-profile from the web server again, but I don't think its that big of a benefit. Ideally, the new URL works exactly like the "Download Thrift Profile" link; you can copy the URL and curl it, you can download the file, you can open it in a new tab. -- To view, visit http://gerrit.cloudera.org:8080/13333 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie030c2bb330211f51840417b9f7880f19174af7b Gerrit-Change-Number: 13333 Gerrit-PatchSet: 1 Gerrit-Owner: Yongzhi Chen <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Yongzhi Chen <[email protected]> Gerrit-Comment-Date: Wed, 15 May 2019 00:24:04 +0000 Gerrit-HasComments: Yes
