Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13333 )
Change subject: IMPALA-6903: Download profile from WebUI in text format ...................................................................... Patch Set 3: (3 comments) I think its safe to assume that executed queries always go to the impalad with port 25000, that seems to be the assumption in all the other tests as well http://gerrit.cloudera.org:8080/#/c/13333/3/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/13333/3/tests/webserver/test_web_pages.py@554 PS3, Line 554: profile_page_url = "{0}query_profile?query_id={1}".format( > this seems a little odd, especially because self.ROOT_URL requires formatti Discussed offline, this looks fine. http://gerrit.cloudera.org:8080/#/c/13333/3/tests/webserver/test_web_pages.py@568 PS3, Line 568: self.ROOT_URL + download_link, query, self.IMPALAD_TEST_PORT) > self.ROOT_URL.format(download_link) Discussed offline, this looks fine. http://gerrit.cloudera.org:8080/#/c/13333/3/tests/webserver/test_web_pages.py@572 PS3, Line 572: self.client.close_query(query_handle) this should be in a "finally" block -- To view, visit http://gerrit.cloudera.org:8080/13333 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie030c2bb330211f51840417b9f7880f19174af7b Gerrit-Change-Number: 13333 Gerrit-PatchSet: 3 Gerrit-Owner: Yongzhi Chen <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Yongzhi Chen <[email protected]> Gerrit-Comment-Date: Tue, 21 May 2019 17:14:07 +0000 Gerrit-HasComments: Yes
