Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13333 )
Change subject: IMPALA-6903: Download profile from WebUI in text format ...................................................................... Patch Set 4: (16 comments) http://gerrit.cloudera.org:8080/#/c/13333/4/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/13333/4/be/src/service/impala-http-handler.cc@247 PS4, Line 247: TUniqueId unique_id; tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13333/4/be/src/service/impala-http-handler.cc@248 PS4, Line 248: stringstream ss; tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13333/4/be/src/service/impala-http-handler.cc@249 PS4, Line 249: Status status = ParseIdFromRequest(req, &unique_id, "query_id"); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13333/4/be/src/service/impala-http-handler.cc@250 PS4, Line 250: if (!status.ok()) { tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13333/4/be/src/service/impala-http-handler.cc@251 PS4, Line 251: ss << status.GetDetail(); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13333/4/be/src/service/impala-http-handler.cc@252 PS4, Line 252: } else { tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13333/4/be/src/service/impala-http-handler.cc@253 PS4, Line 253: Status status = server_->GetRuntimeProfileOutput( tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13333/4/be/src/service/impala-http-handler.cc@254 PS4, Line 254: unique_id, "", format, &ss, nullptr); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13333/4/be/src/service/impala-http-handler.cc@255 PS4, Line 255: if (!status.ok()) { tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13333/4/be/src/service/impala-http-handler.cc@256 PS4, Line 256: ss.str(Substitute("Could not obtain runtime profile: $0", status.GetDetail())); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13333/4/be/src/service/impala-http-handler.cc@257 PS4, Line 257: } tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13333/4/be/src/service/impala-http-handler.cc@258 PS4, Line 258: } tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13333/4/be/src/service/impala-http-handler.cc@259 PS4, Line 259: document->AddMember(rapidjson::StringRef(Webserver::ENABLE_RAW_HTML_KEY), true, tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13333/4/be/src/service/impala-http-handler.cc@260 PS4, Line 260: document->GetAllocator()); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13333/4/be/src/service/impala-http-handler.cc@261 PS4, Line 261: Value profile(ss.str().c_str(), document->GetAllocator()); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13333/4/be/src/service/impala-http-handler.cc@262 PS4, Line 262: document->AddMember("contents", profile, document->GetAllocator()); tab used for whitespace -- To view, visit http://gerrit.cloudera.org:8080/13333 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie030c2bb330211f51840417b9f7880f19174af7b Gerrit-Change-Number: 13333 Gerrit-PatchSet: 4 Gerrit-Owner: Yongzhi Chen <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Yongzhi Chen <[email protected]> Gerrit-Comment-Date: Wed, 22 May 2019 01:32:55 +0000 Gerrit-HasComments: Yes
