Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14397 )
Change subject: IMPALA-9030: Handle translated external Kudu tables ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/14397/1/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java File fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java: http://gerrit.cloudera.org:8080/#/c/14397/1/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java@120 PS1, Line 120: if (!KuduTable.isExternallyManagedTable(table_.getMetaStoreTable())) { If we use the purge property as mentioned in my other comment, I think this check should be for managed or "external purge" tables. http://gerrit.cloudera.org:8080/#/c/14397/1/fe/src/main/java/org/apache/impala/catalog/KuduTable.java File fe/src/main/java/org/apache/impala/catalog/KuduTable.java: http://gerrit.cloudera.org:8080/#/c/14397/1/fe/src/main/java/org/apache/impala/catalog/KuduTable.java@141 PS1, Line 141: .parseBoolean(msTbl.getParameters().get(TBL_PROP_TRANSLATED_TO_EXTERNAL)); Instead of using the `TRANSLATED_TO_EXTERNAL` property, I think we should use the `external.table.purge=true` property. That is what was used in the Kudu side changes to support this. See the patch for context here: https://gerrit.cloudera.org/#/c/14179/ -- To view, visit http://gerrit.cloudera.org:8080/14397 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I324523361c923b7d291cb4d0f1028b1a5b653b36 Gerrit-Change-Number: 14397 Gerrit-PatchSet: 1 Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Wed, 09 Oct 2019 01:21:46 +0000 Gerrit-HasComments: Yes
