Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14397 )
Change subject: IMPALA-9030: Handle translated external Kudu tables ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/14397/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java File fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java: http://gerrit.cloudera.org:8080/#/c/14397/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java@120 PS2, Line 120: isExternallyManagedTable Would it make sense to check whether the table is managed? E.g. define this as if (KuduTable.isSynchronizedTable(table_.getMetaStoreTable()) { // throw error... } Where KuduTable.isSynchronziedTable() checks for whether it's managed _or_ whether it's external with the purge property? That's along the lines of what Kudu did in https://gerrit.cloudera.org/c/14179/8/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java#285 http://gerrit.cloudera.org:8080/#/c/14397/2/fe/src/main/java/org/apache/impala/catalog/KuduTable.java File fe/src/main/java/org/apache/impala/catalog/KuduTable.java: http://gerrit.cloudera.org:8080/#/c/14397/2/fe/src/main/java/org/apache/impala/catalog/KuduTable.java@141 PS2, Line 141: !Boolean : .parseBoolean Maybe I'm missing something, but if "external.table.purge" is true, shouldn't it be considered externally managed? Why the ! here? -- To view, visit http://gerrit.cloudera.org:8080/14397 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I324523361c923b7d291cb4d0f1028b1a5b653b36 Gerrit-Change-Number: 14397 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Thu, 10 Oct 2019 20:41:13 +0000 Gerrit-HasComments: Yes
