Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14546 )
Change subject: IMPALA-9071: Fix wrong table path of transaction table created by CTAS ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Had some questions about HIVE-22158, but lgtm. http://gerrit.cloudera.org:8080/#/c/14546/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/14546/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@950 PS1, Line 950: external table Will HMS's transformer add the purge property in that case? http://gerrit.cloudera.org:8080/#/c/14546/1/tests/custom_cluster/test_custom_hive_configs.py File tests/custom_cluster/test_custom_hive_configs.py: http://gerrit.cloudera.org:8080/#/c/14546/1/tests/custom_cluster/test_custom_hive_configs.py@47 PS1, Line 47: # Test creating non-ACID managed table by CTAS. HIVE-22158 title says "Disallow non-ACID MANAGED tables." Will it fail, or will it transform it to external table with purge on? Please extend the comment. -- To view, visit http://gerrit.cloudera.org:8080/14546 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b585216e33e4f7962b19ae2351165288691eaf2 Gerrit-Change-Number: 14546 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 25 Oct 2019 10:35:18 +0000 Gerrit-HasComments: Yes
