Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14546 )

Change subject: IMPALA-9071: Fix wrong table path of transaction table created 
by CTAS
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14546/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java:

http://gerrit.cloudera.org:8080/#/c/14546/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@950
PS1, Line 950: external table
> Yes, HMS will add tblproperteis ('TRANSLATED_TO_EXTERNAL'='TRUE', 'external
minor nit: could you mention it in the comment?



--
To view, visit http://gerrit.cloudera.org:8080/14546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b585216e33e4f7962b19ae2351165288691eaf2
Gerrit-Change-Number: 14546
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Fri, 25 Oct 2019 16:43:01 +0000
Gerrit-HasComments: Yes

Reply via email to