Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14546 )
Change subject: IMPALA-9071: Fix wrong table path of transaction table created by CTAS ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/14546/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/14546/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@950 PS1, Line 950: external table > Will HMS's transformer add the purge property in that case? Yes, HMS will add tblproperteis ('TRANSLATED_TO_EXTERNAL'='TRUE', 'external.table.purge'='true') http://gerrit.cloudera.org:8080/#/c/14546/1/tests/custom_cluster/test_custom_hive_configs.py File tests/custom_cluster/test_custom_hive_configs.py: http://gerrit.cloudera.org:8080/#/c/14546/1/tests/custom_cluster/test_custom_hive_configs.py@38 PS1, Line 38: @pytest.mark.xfail(run=True, reason="May fail on Hive3 versions without HIVE-22158") > I think we should drop the xfail. No, we need it. With this patch, we are uncompatible with Hive-3 without HIVE-22158. Because for creating non-ACID managed table by CTAS, we now assume the default table path be in 'metastore.warehouse.external.dir' and will insert into that path. But actually before HIVE-22158, the default table path will still be in 'metastore.warehouse.dir' since the table is managed. The current CDP_BUILD_NUMBER (1352353) does not contain HIVE-22158 so we need this. http://gerrit.cloudera.org:8080/#/c/14546/1/tests/custom_cluster/test_custom_hive_configs.py@47 PS1, Line 47: # Test creating non-ACID managed table by CTAS. > HIVE-22158 title says "Disallow non-ACID MANAGED tables." Will it fail, or Yes, it will be transformed to external table. Extented the comment. -- To view, visit http://gerrit.cloudera.org:8080/14546 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b585216e33e4f7962b19ae2351165288691eaf2 Gerrit-Change-Number: 14546 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 25 Oct 2019 15:30:18 +0000 Gerrit-HasComments: Yes
