Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14546 )

Change subject: IMPALA-9071: Fix wrong table path of transaction table created 
by CTAS
......................................................................


Patch Set 1:

(1 comment)

One small comment, otherwise this is fine with me.

http://gerrit.cloudera.org:8080/#/c/14546/1/tests/custom_cluster/test_custom_hive_configs.py
File tests/custom_cluster/test_custom_hive_configs.py:

http://gerrit.cloudera.org:8080/#/c/14546/1/tests/custom_cluster/test_custom_hive_configs.py@38
PS1, Line 38:   @pytest.mark.xfail(run=True, reason="May fail on Hive3 versions 
without HIVE-22158")
I think we should drop the xfail.



--
To view, visit http://gerrit.cloudera.org:8080/14546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b585216e33e4f7962b19ae2351165288691eaf2
Gerrit-Change-Number: 14546
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Fri, 25 Oct 2019 15:16:47 +0000
Gerrit-HasComments: Yes

Reply via email to