Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14982 )
Change subject: IMPALA-8801: Date type support for ORC scanner ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/14982/2/be/src/exec/orc-column-readers.h File be/src/exec/orc-column-readers.h: http://gerrit.cloudera.org:8080/#/c/14982/2/be/src/exec/orc-column-readers.h@224 PS2, Line 224: public: nit: space is missing? http://gerrit.cloudera.org:8080/#/c/14982/2/be/src/exec/orc-column-readers.h@235 PS2, Line 235: private: nit: space is missing? (see other classes below) http://gerrit.cloudera.org:8080/#/c/14982/2/be/src/exec/orc-column-readers.cc File be/src/exec/orc-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/14982/2/be/src/exec/orc-column-readers.cc@101 PS2, Line 101: case TYPE_DATE: { nit: the braces can be omitted http://gerrit.cloudera.org:8080/#/c/14982/2/be/src/exec/orc-column-readers.cc@213 PS2, Line 213: !dv.IsValid() I think you could add UNLIKELY here. http://gerrit.cloudera.org:8080/#/c/14982/2/fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java File fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java: http://gerrit.cloudera.org:8080/#/c/14982/2/fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java@30 PS2, Line 30: Supported HDFS file formats. Every file format specifies: Not related to this commit specifically, but would be good to have this comment updated with the sixth parameter's description. -- To view, visit http://gerrit.cloudera.org:8080/14982 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I672a2cdd2452a46b676e0e36942fd310f55c4956 Gerrit-Change-Number: 14982 Gerrit-PatchSet: 2 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Comment-Date: Tue, 07 Jan 2020 13:12:11 +0000 Gerrit-HasComments: Yes
