Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/14982 )
Change subject: IMPALA-8801: Date type support for ORC scanner ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14982/2/be/src/exec/orc-metadata-utils.cc File be/src/exec/orc-metadata-utils.cc: http://gerrit.cloudera.org:8080/#/c/14982/2/be/src/exec/orc-metadata-utils.cc@181 PS2, Line 181: case orc::TypeKind::DATE: { : if (type.type == TYPE_DATE) return Status::OK(); : break; : } I think ORC supports schema evolution too. I tested this quickly in Hive: 1. Create an ORC table TBL1 with a DATE column. 2. Create an ORC table TBL2 with a TIMESTAMP column that has the same location as TBL1. 3. Insert some DATE values into TBL1 and some TIMESTAMP values into TBL2. 4. select from TBL1 returns both DATE and TIMESTAMP values (converted to DATE). 5. select from TBL2 returns both DATE and TIMESTAMPS values. The DATE values are converted to TIMESTAMP. -- To view, visit http://gerrit.cloudera.org:8080/14982 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I672a2cdd2452a46b676e0e36942fd310f55c4956 Gerrit-Change-Number: 14982 Gerrit-PatchSet: 2 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 08 Jan 2020 13:21:04 +0000 Gerrit-HasComments: Yes
