Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/14982 )
Change subject: IMPALA-8801: Date type support for ORC scanner ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/14982/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14982/3//COMMIT_MSG@11 PS3, Line 11: Unix epoch using proleptic Gregorian calendar. > I would add "(proleptic Gregorian)", as a big part of the test code deals w Done http://gerrit.cloudera.org:8080/#/c/14982/2/be/src/exec/orc-metadata-utils.cc File be/src/exec/orc-metadata-utils.cc: http://gerrit.cloudera.org:8080/#/c/14982/2/be/src/exec/orc-metadata-utils.cc@181 PS2, Line 181: case orc::TypeKind::DATE: : if (type.type == TYPE_DATE) return Status::OK(); : break; : d > I am not too enthusiastic about adding this feature now. My main concern is I gave this a quick look an it seems that supporting the use case mentioned by Attila is not that straightforward either. - After extending this check here to "type == TYPE_DATE || type == TYPE_TIMESTAMP" causes issues in OrcDateColumnReader::UpdateInputBatch() where a DCHECK fails. - I could get around this by doing a timestamp cast if the date cast fails but in order to do this batch_ has to be ColumnVectorBatch instead of LongVectorBatch as that is the common parent of the date and timestamp representations. - Once doing this L??? in OrcDateColumnReader::ReadValue() doesn't compile as ColumnVectorBatch doesn't have a member called data. There would be multiple ways to get around these but in my opinion it would require more efforts that doing this as a review comment. What about opening a Jira for this? -- To view, visit http://gerrit.cloudera.org:8080/14982 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I672a2cdd2452a46b676e0e36942fd310f55c4956 Gerrit-Change-Number: 14982 Gerrit-PatchSet: 4 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 09 Jan 2020 10:54:31 +0000 Gerrit-HasComments: Yes
