Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/14982 )
Change subject: IMPALA-8801: Date type support for ORC scanner ...................................................................... Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/14982/2/be/src/exec/orc-column-readers.h File be/src/exec/orc-column-readers.h: http://gerrit.cloudera.org:8080/#/c/14982/2/be/src/exec/orc-column-readers.h@224 PS2, Line 224: public: > nit: space is missing? Done http://gerrit.cloudera.org:8080/#/c/14982/2/be/src/exec/orc-column-readers.h@235 PS2, Line 235: private: > nit: space is missing? (see other classes below) Done http://gerrit.cloudera.org:8080/#/c/14982/2/be/src/exec/orc-column-readers.cc File be/src/exec/orc-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/14982/2/be/src/exec/orc-column-readers.cc@101 PS2, Line 101: case TYPE_DATE: > nit: the braces can be omitted Done http://gerrit.cloudera.org:8080/#/c/14982/2/be/src/exec/orc-column-readers.cc@213 PS2, Line 213: tNullSlot(tup > I think you could add UNLIKELY here. Done http://gerrit.cloudera.org:8080/#/c/14982/2/be/src/exec/orc-metadata-utils.cc File be/src/exec/orc-metadata-utils.cc: http://gerrit.cloudera.org:8080/#/c/14982/2/be/src/exec/orc-metadata-utils.cc@181 PS2, Line 181: > nit: extra braces Done http://gerrit.cloudera.org:8080/#/c/14982/2/fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java File fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java: http://gerrit.cloudera.org:8080/#/c/14982/2/fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java@30 PS2, Line 30: Supported HDFS file formats. Every file format specifies: > Not related to this commit specifically, but would be good to have this com Done http://gerrit.cloudera.org:8080/#/c/14982/2/testdata/workloads/functional-query/queries/QueryTest/date-fileformat-support.test File testdata/workloads/functional-query/queries/QueryTest/date-fileformat-support.test: http://gerrit.cloudera.org:8080/#/c/14982/2/testdata/workloads/functional-query/queries/QueryTest/date-fileformat-support.test@112 PS2, Line 112: : > we might not need this query anymore since now we query the whole table in Done -- To view, visit http://gerrit.cloudera.org:8080/14982 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I672a2cdd2452a46b676e0e36942fd310f55c4956 Gerrit-Change-Number: 14982 Gerrit-PatchSet: 3 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 08 Jan 2020 12:55:31 +0000 Gerrit-HasComments: Yes
