Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 )
Change subject: IMPALA-9010: Add builtin mask functions ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/14963/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14963/2//COMMIT_MSG@34 PS2, Line 34: numberChar - character to replace digits in a number with. Valid : values: 0-9. Default value: '1' > nit: Is it better to add "Specify -1 to retain original character" as the d Sorry I meant to say "Specify -1 to use the default value, i.e., 1" (if my understanding is correct). http://gerrit.cloudera.org:8080/#/c/14963/2/be/src/exprs/mask-functions.h File be/src/exprs/mask-functions.h: http://gerrit.cloudera.org:8080/#/c/14963/2/be/src/exprs/mask-functions.h@59 PS2, Line 59: /// numberChar - character to replace digits in a number with. Valid values: 0-9. : /// Default value: '1' > nit: Is it better to add "Specify -1 to retain original character" as in th Sorry I meant to say "Specify -1 to use the default value, i.e., 1" (if my understanding is correct). -- To view, visit http://gerrit.cloudera.org:8080/14963 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica779a1bf63a085d51f3b533f654cbaac102a664 Gerrit-Change-Number: 14963 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 09 Jan 2020 01:44:33 +0000 Gerrit-HasComments: Yes
