Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 )
Change subject: IMPALA-9010: Add builtin mask functions ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/14963/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14963/2//COMMIT_MSG@25 PS2, Line 25: number of characters nit: Is it better to use "number of characters to retain" to make it clearer? http://gerrit.cloudera.org:8080/#/c/14963/2/be/src/exprs/mask-functions.h File be/src/exprs/mask-functions.h: http://gerrit.cloudera.org:8080/#/c/14963/2/be/src/exprs/mask-functions.h@50 PS2, Line 50: number of characters nit: Is it better to use "number of characters to retain" to make it clearer? -- To view, visit http://gerrit.cloudera.org:8080/14963 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica779a1bf63a085d51f3b533f654cbaac102a664 Gerrit-Change-Number: 14963 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 09 Jan 2020 03:56:33 +0000 Gerrit-HasComments: Yes
