Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 )
Change subject: IMPALA-9010: Add builtin mask functions ...................................................................... Patch Set 5: Code-Review+1 (4 comments) Thanks Quanlong for your patience and the detailed responses! I do not have any other comment. http://gerrit.cloudera.org:8080/#/c/14963/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14963/2//COMMIT_MSG@25 PS2, Line 25: number of characters > I'm afraid not. It has different meanings in different functions. In mask_s Thanks Quanlong for your patience and detailed explanation! The documents are very helpful. http://gerrit.cloudera.org:8080/#/c/14963/2//COMMIT_MSG@30 PS2, Line 30: digitChar - character to replace digit characters with. Specify -1 : to retain original character. Default value: 'n' > digitChar is used for string values. numberChar is used for numeric values. Thanks Quanlong for this concrete example! http://gerrit.cloudera.org:8080/#/c/14963/2//COMMIT_MSG@34 PS2, Line 34: numberChar - character to replace digits in a number with. Valid : values: 0-9. Default value: '1' > -1 is an invalid value for numberChar. All invalid values will be treated a Thanks for the clarification! http://gerrit.cloudera.org:8080/#/c/14963/2/be/src/exprs/mask-functions.h File be/src/exprs/mask-functions.h: http://gerrit.cloudera.org:8080/#/c/14963/2/be/src/exprs/mask-functions.h@59 PS2, Line 59: /// numberChar - character to replace digits in a number with. Valid values: 0-9. : /// Default value: '1' > -1 is an invalid value for numberChar. All invalid values (-1, 10, 99...) w Thanks for the clarification! -- To view, visit http://gerrit.cloudera.org:8080/14963 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica779a1bf63a085d51f3b533f654cbaac102a664 Gerrit-Change-Number: 14963 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Norbert Luksa <norbert.lu...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Mon, 13 Jan 2020 04:49:32 +0000 Gerrit-HasComments: Yes
