Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 )
Change subject: IMPALA-9010: Add builtin mask functions ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14963/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14963/2//COMMIT_MSG@30 PS2, Line 30: digitChar - character to replace digit characters with. Specify -1 : to retain original character. Default value: 'n' After reading the description, I found that the difference between 'digitChar' and 'numberChar' is not that clear to me. For example, according to the test case at https://gerrit.cloudera.org/c/14963/2/be/src/exprs/expr-test.cc#10114, "mask_show_first_n(cast(12345 as smallint), 3, 'x', 'x', 'x', -1, '5')" would be transformed into "12355" because the first 3 characters are retained and each digit in the rest of the number is replaced with '5', which is specified by the parameter of 'numberChar'. However, if this is the case, then what is the purpose of the parameter 'digitChar'? Does 'numberChar' take precedence over 'digitChar'? I think I might have missed something. But I think it might be a good idea to elaborate more on this or even provide some concrete examples. -- To view, visit http://gerrit.cloudera.org:8080/14963 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica779a1bf63a085d51f3b533f654cbaac102a664 Gerrit-Change-Number: 14963 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 09 Jan 2020 04:30:05 +0000 Gerrit-HasComments: Yes
