Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/14982 )
Change subject: IMPALA-8801: Date type support for ORC scanner ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/14982/2/be/src/exec/orc-metadata-utils.cc File be/src/exec/orc-metadata-utils.cc: http://gerrit.cloudera.org:8080/#/c/14982/2/be/src/exec/orc-metadata-utils.cc@181 PS2, Line 181: case orc::TypeKind::DATE: : if (type.type == TYPE_DATE) return Status::OK(); : break; : d > I'm ok to do this in another JIRA. Thanks for the explanation Quanlong! I oepened a separate Jira for this: https://issues.apache.org/jira/browse/IMPALA-9290 One thing I don't get here. If I leave this file intact then I get the "Type mismatch" below. If I extend the DATE case to also allow "type.type == TYPE_TIMESTAMP" then the DCHECK fails in UpdateInputBatch(). http://gerrit.cloudera.org:8080/#/c/14982/4/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/14982/4/tests/query_test/test_scanners.py@352 PS4, Line 352: def test_parquet(self, vector): : self.run_test_case('QueryTest/parquet', vector) : : def test_corrupt_files(self, vector): : new_vector = deepcopy(vector) : del new_vector.get_value('exec_option')['num_nodes'] # .test file sets num_nodes : new_vector.get_value('exec_option')['abort_on_error'] = 0 : self.run_test_case('QueryTest/parquet-continue-on-error', new_vector) : new_vector.get_value('exec_option')['abort_on_error'] = 1 : self.run_test_case('QueryTest/parquet-abort-on-error', new_vector) : : def test_timestamp_out_of_range(self, vector, unique_database): : """IMPALA-4363: Test scanning parquet files with an out of range timestamp. : Also tests IMPALA-7595: Test Parquet timestamp columns where the time part : is out of the valid range [0..24H). : """ : # out of range date part : create_table_from_parquet(self.client, unique_database, "out_of_range_timestamp") : : # out of range time part : create_table_from_parquet(self.client, unique_database, "out_of_range_time_of_day") : > These tests are related to ORC, but we are in class TestParquet. Indeed :) Done -- To view, visit http://gerrit.cloudera.org:8080/14982 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I672a2cdd2452a46b676e0e36942fd310f55c4956 Gerrit-Change-Number: 14982 Gerrit-PatchSet: 5 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Norbert Luksa <norbert.lu...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Mon, 13 Jan 2020 13:54:54 +0000 Gerrit-HasComments: Yes
