Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14982 )
Change subject: IMPALA-8801: Date type support for ORC scanner ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/14982/4/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/14982/4/tests/query_test/test_scanners.py@352 PS4, Line 352: orc_tbl_name = "out_of_range_date_orc" : create_sql = "create table %s.%s (d date) stored as orc" % (unique_database, : orc_tbl_name) : create_table_and_copy_files(self.client, create_sql, unique_database, orc_tbl_name, : ["/testdata/data/out_of_range_date.orc"]) : : new_vector = deepcopy(vector) : del new_vector.get_value('exec_option')['abort_on_error'] : self.run_test_case('QueryTest/out-of-range-date', new_vector, unique_database) : : def test_pre_gregorian_date(self, vector, unique_database): : """Test date interoperability issues between Impala and Hive 2.1.1 when scanning : a parquet table that contains dates that precede the introduction of Gregorian : calendar in 1582-10-15. : """ : create_table_from_parquet(self.client, unique_database, "hive2_pre_gregorian") : : orc_tbl_name = "hive2_pre_gregorian_orc" : create_sql = "create table %s.%s (d date) stored as orc" % (unique_database, : orc_tbl_name) : create_table_and_copy_files(self.client, create_sql, unique_database, orc_tbl_name, : ["/testdata/data/hive2_pre_gregorian.orc"]) These tests are related to ORC, but we are in class TestParquet. -- To view, visit http://gerrit.cloudera.org:8080/14982 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I672a2cdd2452a46b676e0e36942fd310f55c4956 Gerrit-Change-Number: 14982 Gerrit-PatchSet: 4 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 09 Jan 2020 16:22:39 +0000 Gerrit-HasComments: Yes
