Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14197 )
Change subject: IMPALA-5092 Add support for VARCHAR in Kudu tables ...................................................................... Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/14197/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14197/10//COMMIT_MSG@9 PS10, Line 9: KUDU-1938 added VARCHAR column type support to Kudu Can you add some information about how Kudu supports VARCHAR? It is also ok to add a link. Some topics I am interested in: - Does Kudu treat VARCHAR differently than STRING? Does it enforce enforce the length constraint (so Impala doesn't have to)? (I guess yes, but it would be useful to highlight it here) - Does Kudu care about the encoding of the string? Is the length of the string always the number of bytes? (I remember that we discussed in the path, but I don't remember how it ended up). - How do we push down min/max predicates? It is valid in Impala to compare a VARCHAR to a STRING, and it matters whether the string is truncated before push down. Do we push it down to Kudu in this case? I think that the correct way is pushing it down without truncation. http://gerrit.cloudera.org:8080/#/c/14197/10/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test File testdata/workloads/functional-query/queries/QueryTest/kudu_create.test: http://gerrit.cloudera.org:8080/#/c/14197/10/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test@361 PS10, Line 361: select * from ctas_varchar; If I didn't miss something then this was the only test where the primary key is varchar. We should also test the case when there are predicates against it (both comparing it to STRINGs and VARCHARs) + the partitioned case also seems interesting. http://gerrit.cloudera.org:8080/#/c/14197/10/testdata/workloads/functional-query/queries/QueryTest/kudu_upsert.test File testdata/workloads/functional-query/queries/QueryTest/kudu_upsert.test: http://gerrit.cloudera.org:8080/#/c/14197/10/testdata/workloads/functional-query/queries/QueryTest/kudu_upsert.test@413 PS10, Line 413: nit: trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/14197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d4959410fdd882bfa980cb55e8a7837c7823da8 Gerrit-Change-Number: 14197 Gerrit-PatchSet: 10 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Mon, 17 Feb 2020 18:41:18 +0000 Gerrit-HasComments: Yes
