Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14197 )
Change subject: IMPALA-5092 Add support for VARCHAR in Kudu tables ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/14197/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14197/12//COMMIT_MSG@12 PS12, Line 12: VARCHAR length is enforced in the Kudu client, Impala doesn't have to : enforce it further. The length of the VARCHAR is given in characters : (UTF8) so a VARCHAR(n) is stored in "n" to "4n" bytes. > This actually means that Impala has to enforce it during reading, as the le Relatedly, are there any test cases that cover strings with multi byte characters? http://gerrit.cloudera.org:8080/#/c/14197/12//COMMIT_MSG@19 PS12, Line 19: TODO: add tests for the scenario where the primary key is varchar + : predicates and partitioning > ok, we can add these tests in a later commit from my side Another test case I'd like to see (can also be left for followup work): min-max runtime filters, i.e. in testdata/workloads/functional-query/queries/QueryTest/min_max_filters.test -- To view, visit http://gerrit.cloudera.org:8080/14197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d4959410fdd882bfa980cb55e8a7837c7823da8 Gerrit-Change-Number: 14197 Gerrit-PatchSet: 12 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Tue, 10 Mar 2020 18:16:39 +0000 Gerrit-HasComments: Yes
