Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14197 )
Change subject: IMPALA-5092 Add support for VARCHAR in Kudu tables ...................................................................... Patch Set 12: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/14197/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14197/12//COMMIT_MSG@12 PS12, Line 12: VARCHAR length is enforced in the Kudu client, Impala doesn't have to : enforce it further. The length of the VARCHAR is given in characters : (UTF8) so a VARCHAR(n) is stored in "n" to "4n" bytes. This actually means that Impala has to enforce it during reading, as the length is the number of bytes in Impala, right? So we have to truncate it after receiving the string from Kudu if it has multy byte characters. http://gerrit.cloudera.org:8080/#/c/14197/12//COMMIT_MSG@17 PS12, Line 17: in client-side. You mean on Impala side? http://gerrit.cloudera.org:8080/#/c/14197/12//COMMIT_MSG@19 PS12, Line 19: TODO: add tests for the scenario where the primary key is varchar + : predicates and partitioning ok, we can add these tests in a later commit from my side -- To view, visit http://gerrit.cloudera.org:8080/14197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d4959410fdd882bfa980cb55e8a7837c7823da8 Gerrit-Change-Number: 14197 Gerrit-PatchSet: 12 Gerrit-Owner: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com> Gerrit-Comment-Date: Tue, 10 Mar 2020 16:22:43 +0000 Gerrit-HasComments: Yes
