Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/14197 )
Change subject: IMPALA-5092 Add support for VARCHAR in Kudu tables ...................................................................... Patch Set 10: (2 comments) Thank you for the change. I did a first pass and found two small nits. Will do a quick test locally as well later today/tomorrow. http://gerrit.cloudera.org:8080/#/c/14197/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14197/10//COMMIT_MSG@11 PS10, Line 11: Usually, Impala commit messages also have a section "Testing" to mention the tests added by this commit. This will help reviewers understand the testing done for the patch. See this for example. https://gerrit.cloudera.org/#/c/15157/ http://gerrit.cloudera.org:8080/#/c/14197/10/be/src/exec/kudu-util.cc File be/src/exec/kudu-util.cc: http://gerrit.cloudera.org:8080/#/c/14197/10/be/src/exec/kudu-util.cc@139 PS10, Line 139: nit: Indentation should be 4 in these cases. -- To view, visit http://gerrit.cloudera.org:8080/14197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d4959410fdd882bfa980cb55e8a7837c7823da8 Gerrit-Change-Number: 14197 Gerrit-PatchSet: 10 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Tue, 18 Feb 2020 09:38:13 +0000 Gerrit-HasComments: Yes
