Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15132 )
Change subject: IMPALA-3343: Make impala-shell compatible with python 3. ...................................................................... Patch Set 15: (4 comments) http://gerrit.cloudera.org:8080/#/c/15132/15/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/15132/15/shell/impala_shell.py@962 PS15, Line 962: if flush is True: nit: "if flush" might be more pythonic http://gerrit.cloudera.org:8080/#/c/15132/15/shell/thrift_sasl.py File shell/thrift_sasl.py: http://gerrit.cloudera.org:8080/#/c/15132/15/shell/thrift_sasl.py@23 PS15, Line 23: # Initially copied from the Impala repo Comment probably needs updating? http://gerrit.cloudera.org:8080/#/c/15132/15/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/15132/15/tests/shell/test_shell_commandline.py@485 PS15, Line 485: if SHELL_IS_PYTHON_2: I don't think I quite understand this - based on the control flow it seems like this is breaking on beeswax, not HS2 (the assert below should only raise an exception if this fails on beeswax). http://gerrit.cloudera.org:8080/#/c/15132/15/tests/shell/test_shell_commandline.py@1004 PS15, Line 1004: he the nit: repeated word -- To view, visit http://gerrit.cloudera.org:8080/15132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb75e162bac0faeae3e12106c15da39cbfb8b462 Gerrit-Change-Number: 15132 Gerrit-PatchSet: 15 Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 25 Feb 2020 19:46:38 +0000 Gerrit-HasComments: Yes
