Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15132 )
Change subject: IMPALA-3343: Make impala-shell compatible with python 3. ...................................................................... Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/15132/15/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/15132/15/tests/shell/test_shell_commandline.py@485 PS15, Line 485: if SHELL_IS_PYTHON_2: > The primary assert happens above this line, regardless of python version. I got confused by the scenario, but I checked this out and played around and understand now. I think this regression is kinda bad, this would affect anyone using non-ascii characters with HS2. I think if we don't fix it it's important to check that the fallback logic also works for HS2, since that's the behaviour in this patchset (so the test shouldn't be skipped either way). FWIW I played around to understand and it looks like the issue on python2 is fixed by this, at least when I'm running impala-shell.sh + column_names = [cname.decode('utf8') for cname in self.imp_client.get_column_names(self.last_query_handle)] - column_names = self.imp_client.get_column_names(self.last_query_handle) impala-shell.sh -q 'select "?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?,"' -- To view, visit http://gerrit.cloudera.org:8080/15132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb75e162bac0faeae3e12106c15da39cbfb8b462 Gerrit-Change-Number: 15132 Gerrit-PatchSet: 15 Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 27 Feb 2020 22:11:37 +0000 Gerrit-HasComments: Yes
