David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15132 )
Change subject: IMPALA-3343: Make impala-shell compatible with python 3. ...................................................................... Patch Set 16: (4 comments) http://gerrit.cloudera.org:8080/#/c/15132/15/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/15132/15/shell/impala_shell.py@962 PS15, Line 962: if flush: > nit: "if flush" might be more pythonic Done http://gerrit.cloudera.org:8080/#/c/15132/15/shell/thrift_sasl.py File shell/thrift_sasl.py: http://gerrit.cloudera.org:8080/#/c/15132/15/shell/thrift_sasl.py@23 PS15, Line 23: # Initially copied from the Impala repo > Comment probably needs updating? I think I meant the thrift_sasl repo, and I just made a mistake? In any event, this file will get a wholesale replacement soon, since thrift_sasl.py has been updated upstream. I'll wait until IMPALA-9424 (https://gerrit.cloudera.org/c/15293/) is merged, and then I'll replace this file here. http://gerrit.cloudera.org:8080/#/c/15132/15/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/15132/15/tests/shell/test_shell_commandline.py@485 PS15, Line 485: if SHELL_IS_PYTHON_2: > I don't think I quite understand this - based on the control flow it seems The primary assert happens above this line, regardless of python version. if protocol == 'beeswax': assert 'Reverting to tab delimited text' in result.stderr So, if protocol is beeswax, assert as expected. Else if protocol is NOT beeswax, check if SHELL_IS_PYTHON_2, and if so, just skip. However, if protocol is NOT beeswax, but shell is python 3 (or, presumably, above 3 some day) then proceed with test to the end. Please let me know if I should re-order this to make it more legible. Honestly, this comment almost makes me think we should just skip altogether if not beeswax. # HS2 does not need to fall back, but should behave appropriately. http://gerrit.cloudera.org:8080/#/c/15132/15/tests/shell/test_shell_commandline.py@1004 PS15, Line 1004: he > nit: repeated word Done -- To view, visit http://gerrit.cloudera.org:8080/15132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb75e162bac0faeae3e12106c15da39cbfb8b462 Gerrit-Change-Number: 15132 Gerrit-PatchSet: 16 Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 26 Feb 2020 00:42:47 +0000 Gerrit-HasComments: Yes
