David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15132 )
Change subject: IMPALA-3343: Make impala-shell compatible with python 3. ...................................................................... Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/15132/15/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/15132/15/tests/shell/test_shell_commandline.py@485 PS15, Line 485: if SHELL_IS_PYTHON_2: > I got confused by the scenario, but I checked this out and played around an Still digging into this. The proposed change of cname.decode('utf8') fails under python 3 because with python 3: 'str' object has no attribute 'decode' In the meantime, with that change, the test against the built tarball still fails: E Query: select '?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?,?, ?, ?, ?, ?, ?,?, ?, ?, ?, ?, ?, ?, ?, ?\t' E Query submitted at: 2020-03-02 14:06:17 (Coordinator: http://dknupp-desktop:25000) E Query progress can be monitored at: http://dknupp-desktop:25000/query_plan?query_id=c649f690ad99d702:8571f57400000000 E Unknown Exception : 'ascii' codec can't encode character u'\u0430' in position 107: ordinal not in range(128) E Traceback (most recent call last): E File "/home/dknupp/Impala/shell/build/impala-shell-3.4.0-SNAPSHOT/impala_shell.py", line 1934, in <module> E impala_shell_main() E File "/home/dknupp/Impala/shell/build/impala-shell-3.4.0-SNAPSHOT/impala_shell.py", line 1888, in impala_shell_main E if execute_queries_non_interactive_mode(options, query_options): E File "/home/dknupp/Impala/shell/build/impala-shell-3.4.0-SNAPSHOT/impala_shell.py", line 1697, in execute_queries_non_interactive_mode E shell.execute_query_list(queries)) E File "/home/dknupp/Impala/shell/build/impala-shell-3.4.0-SNAPSHOT/impala_shell.py", line 1531, in execute_query_list E print('Could not execute command: %s' % q, file=sys.stderr) E UnicodeEncodeError: 'ascii' codec can't encode character u'\u0410' in position 35: ordinal not in range(128) -- To view, visit http://gerrit.cloudera.org:8080/15132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb75e162bac0faeae3e12106c15da39cbfb8b462 Gerrit-Change-Number: 15132 Gerrit-PatchSet: 17 Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 02 Mar 2020 22:09:55 +0000 Gerrit-HasComments: Yes
