David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15284 )
Change subject: IMPALA-9414 (part 2): Support the 'Expect: 100-continue' http header ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/15284/6/shell/THttpClient.py File shell/THttpClient.py: http://gerrit.cloudera.org:8080/#/c/15284/6/shell/THttpClient.py@35 PS6, Line 35: class THttpClient(TTransportBase): > I guess I'm not convinced that subclassing is better than straight copying, Actually, I'm wrong about prettytable. I was thinking of sqlparse. Anyway, not a requirement. -- To view, visit http://gerrit.cloudera.org:8080/15284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4153968551acd58b25c7923c2ebf75ee29a7e76b Gerrit-Change-Number: 15284 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 06 Mar 2020 18:05:11 +0000 Gerrit-HasComments: Yes
