Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15284 )
Change subject: IMPALA-9414 (part 2): Support the 'Expect: 100-continue' http header ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/15284/5/be/src/transport/THttpTransport.cpp File be/src/transport/THttpTransport.cpp: http://gerrit.cloudera.org:8080/#/c/15284/5/be/src/transport/THttpTransport.cpp@255 PS5, Line 255: if (continue_) { Are there any cases in which we'd wish to reject the request (based on the size, etc?). I think probably not but maybe best to add a brief comment to document the intent. E.g. something like "Tell the client to continue with the request, no additional validation of request headers is required". http://gerrit.cloudera.org:8080/#/c/15284/5/be/src/transport/THttpTransport.cpp@257 PS5, Line 257: h << "HTTP/1.1 100 Continue" << CRLF << CRLF; Maybe reference Section 8.2.3 of RFC2616. I found it useful when understanding this. https://www.w3.org/Protocols/rfc2616/rfc2616-sec8.html http://gerrit.cloudera.org:8080/#/c/15284/5/shell/THttpClient.py File shell/THttpClient.py: http://gerrit.cloudera.org:8080/#/c/15284/5/shell/THttpClient.py@166 PS5, Line 166: if data_len > 1024: Make 1024 a constant? Maybe add some explanation of the size? -- To view, visit http://gerrit.cloudera.org:8080/15284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4153968551acd58b25c7923c2ebf75ee29a7e76b Gerrit-Change-Number: 15284 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 05 Mar 2020 02:34:36 +0000 Gerrit-HasComments: Yes
