Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15284 )
Change subject: IMPALA-9414 (part 2): Support the 'Expect: 100-continue' http header ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/15284/5/be/src/transport/THttpTransport.cpp File be/src/transport/THttpTransport.cpp: http://gerrit.cloudera.org:8080/#/c/15284/5/be/src/transport/THttpTransport.cpp@255 PS5, Line 255: > Are there any cases in which we'd wish to reject the request (based on the That's a good question. There's definitely a lot of room for improvements around the hs2 http interface for preventing problems from poorly behaving or malicious clients. I don't think that this patch makes that any worse though, so I think its fine to leave it for followup work. I'll add more comments though. http://gerrit.cloudera.org:8080/#/c/15284/5/be/src/transport/THttpTransport.cpp@257 PS5, Line 257: // header, we respond that it can continue with sending the request. See Section 8.2.3 > Maybe reference Section 8.2.3 of RFC2616. I found it useful when understand Done -- To view, visit http://gerrit.cloudera.org:8080/15284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4153968551acd58b25c7923c2ebf75ee29a7e76b Gerrit-Change-Number: 15284 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 05 Mar 2020 19:55:53 +0000 Gerrit-HasComments: Yes
