Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15673 )
Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15673/1/be/src/runtime/runtime-filter.cc File be/src/runtime/runtime-filter.cc: http://gerrit.cloudera.org:8080/#/c/15673/1/be/src/runtime/runtime-filter.cc@31 PS1, Line 31: DCHECK(!HasFilter()) << "SetFilter() should not be called multiple times."; > nit: we generally use braces to denote the critical section instead of call Done Move the DCHECKs within critical section as well, just to be safe. -- To view, visit http://gerrit.cloudera.org:8080/15673 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7dffa626103ef0af06ad1e89231b0d2ee54bb94a Gerrit-Change-Number: 15673 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 07 Apr 2020 19:55:10 +0000 Gerrit-HasComments: Yes
