Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15673 )
Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival ...................................................................... Patch Set 4: (1 comment) LGTM aside from a minor nit. I'll +2 and start the merge after that's fixed. http://gerrit.cloudera.org:8080/#/c/15673/4/be/src/runtime/runtime-filter-test.cc File be/src/runtime/runtime-filter-test.cc: http://gerrit.cloudera.org:8080/#/c/15673/4/be/src/runtime/runtime-filter-test.cc@21 PS4, Line 21: #include "common/names.h" missed this earlier - common/names.h should go after all the other includes in a separate block. It's a special header that imports names into the global namespace based on which headers preceded it (so you want it last). -- To view, visit http://gerrit.cloudera.org:8080/15673 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7dffa626103ef0af06ad1e89231b0d2ee54bb94a Gerrit-Change-Number: 15673 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 08 Apr 2020 19:04:11 +0000 Gerrit-HasComments: Yes
