Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15673 )
Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival ...................................................................... Patch Set 3: Patch Set 3 add new be test, runtime-filter-test.cc. This test force the race condition that is happen in IMPALA-9612. To do so, it instrument RuntimeFilter code to inject delay in the critical section of function WaitForArrival. The assertion is that arrival_time_ should be >= injected delay, because WaitForArrival should maintain mutual exclusion, and RuntimeFilter should stop waiting once Cancel or SetFilter pass through. -- To view, visit http://gerrit.cloudera.org:8080/15673 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7dffa626103ef0af06ad1e89231b0d2ee54bb94a Gerrit-Change-Number: 15673 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 08 Apr 2020 15:57:54 +0000 Gerrit-HasComments: No
