Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15673 )
Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival ...................................................................... Patch Set 4: (5 comments) Thanks, Tim! Learn new stuff today. In this Patch Set 4, I also wrap delay injection code with NDEBUG macro so that it will be gone in release build. http://gerrit.cloudera.org:8080/#/c/15673/3/be/src/runtime/runtime-filter-test.cc File be/src/runtime/runtime-filter-test.cc: http://gerrit.cloudera.org:8080/#/c/15673/3/be/src/runtime/runtime-filter-test.cc@51 PS3, Line 51: t that Runt > nit: CallWaitFor() according to the style guide: https://google.github.io/s Replaced with lambda. http://gerrit.cloudera.org:8080/#/c/15673/3/be/src/runtime/runtime-filter-test.cc@52 PS3, Line 52: // See IMPALA-9612. > nit: we use c++-style casts. reinterpret_cast<TestConfig>(...) in this case Gone, replaced with lambda. http://gerrit.cloudera.org:8080/#/c/15673/3/be/src/runtime/runtime-filter-test.cc@54 PS3, Line 54: eFil > nit: nullptr Gone, replaced with lambda. http://gerrit.cloudera.org:8080/#/c/15673/3/be/src/runtime/runtime-filter-test.cc@82 PS3, Line 82: MinMaxFilter::Create(ColumnType(PrimitiveType::TYPE_BOOLEAN), &pool_, &tracker_); > We use C++-style threads in the codebase which wrap pthreads and provide so Done http://gerrit.cloudera.org:8080/#/c/15673/3/be/src/runtime/runtime-filter-test.cc@109 PS3, Line 109: > nit: a head Done -- To view, visit http://gerrit.cloudera.org:8080/15673 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7dffa626103ef0af06ad1e89231b0d2ee54bb94a Gerrit-Change-Number: 15673 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 08 Apr 2020 18:53:15 +0000 Gerrit-HasComments: Yes
