Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15793 )
Change subject: IMPALA-9609: Minimize Frontend activity in executor only impalads ...................................................................... Patch Set 2: (1 comment) Thanks for fixing this, it should help a lot. http://gerrit.cloudera.org:8080/#/c/15793/2/fe/src/main/java/org/apache/impala/service/JniFrontend.java File fe/src/main/java/org/apache/impala/service/JniFrontend.java: http://gerrit.cloudera.org:8080/#/c/15793/2/fe/src/main/java/org/apache/impala/service/JniFrontend.java@191 PS2, Line 191: ExecutorMembershipSnapshot.update(req); Removing the indirection makes sense. Can we go further and just not do the JNI call at all when it's not a coordinator (i.e. skip calling SendClusterMembershipToFrontend()) be/src/runtime/exec-env.cc -- To view, visit http://gerrit.cloudera.org:8080/15793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4627e5e3520175153cb49e24fd480815dfefdae1 Gerrit-Change-Number: 15793 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 24 Apr 2020 00:30:34 +0000 Gerrit-HasComments: Yes
