Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15793 )
Change subject: IMPALA-9609: Minimize Frontend activity in executor only impalads ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/15793/2/fe/src/main/java/org/apache/impala/service/JniFrontend.java File fe/src/main/java/org/apache/impala/service/JniFrontend.java: http://gerrit.cloudera.org:8080/#/c/15793/2/fe/src/main/java/org/apache/impala/service/JniFrontend.java@146 PS2, Line 146: frontend_ = null; > With this set to null, to be safe it would be good to add Preconditions not Added the Preconditions. My idea for making this class nicer was to make all functions needed by executors static and create a JniFrontend in backend only for coordinators. I didn't do this change because I wanted to minimize the size and risks of this patch to make it easily backportable. http://gerrit.cloudera.org:8080/#/c/15793/2/fe/src/main/java/org/apache/impala/service/JniFrontend.java@191 PS2, Line 191: ExecutorMembershipSnapshot.update(req); > Removing the indirection makes sense. Can we go further and just not do the Done -- To view, visit http://gerrit.cloudera.org:8080/15793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4627e5e3520175153cb49e24fd480815dfefdae1 Gerrit-Change-Number: 15793 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 24 Apr 2020 14:49:31 +0000 Gerrit-HasComments: Yes
