Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15793 )
Change subject: IMPALA-9609: Minimize Frontend activity in executor only impalads ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/15793/3/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: http://gerrit.cloudera.org:8080/#/c/15793/3/be/src/runtime/exec-env.cc@287 PS3, Line 287: // TODO: Consider removing AdmissionController from executor only impalads. We do actually need this on executors at the moment because they add the memory used locally to the admission control updates - see UpdatePoolStats() -> AddPoolUpdates() -> UpdateMemTrackerStats(). It could be refactored but for now it's harmless. -- To view, visit http://gerrit.cloudera.org:8080/15793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4627e5e3520175153cb49e24fd480815dfefdae1 Gerrit-Change-Number: 15793 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 24 Apr 2020 16:52:22 +0000 Gerrit-HasComments: Yes
