Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/15793 )
Change subject: IMPALA-9609: Minimize Frontend activity in executor only impalads ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15793/2/fe/src/main/java/org/apache/impala/service/JniFrontend.java File fe/src/main/java/org/apache/impala/service/JniFrontend.java: http://gerrit.cloudera.org:8080/#/c/15793/2/fe/src/main/java/org/apache/impala/service/JniFrontend.java@146 PS2, Line 146: frontend_ = null; With this set to null, to be safe it would be good to add Preconditions not null check for references to frontend_. The downside is it makes the code ugly since there are lot of references. It almost seems like you need a coordinator-only CoordJniFrontEnd that extends a BaseJniFrontEnd. The executors could only instantiate the BaseJniFrontend. -- To view, visit http://gerrit.cloudera.org:8080/15793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4627e5e3520175153cb49e24fd480815dfefdae1 Gerrit-Change-Number: 15793 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 24 Apr 2020 00:44:59 +0000 Gerrit-HasComments: Yes
