Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15990 )
Change subject: IMPALA-9673: Add external warehouse dir variable in E2E test ...................................................................... Patch Set 4: (4 comments) Needs to be rebased as well. http://gerrit.cloudera.org:8080/#/c/15990/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15990/4//COMMIT_MSG@12 PS4, Line 12: CDPD-8248 this isn't an external JIRA, so we can't reference it here. you probably want to reference the public Apache JIRA instead. http://gerrit.cloudera.org:8080/#/c/15990/4//COMMIT_MSG@18 PS4, Line 18: impala-private-parameterized this isn't a public Jenkins job. You can just say "Ran exhaustive tests" http://gerrit.cloudera.org:8080/#/c/15990/4/testdata/datasets/functional/functional_schema_template.sql File testdata/datasets/functional/functional_schema_template.sql: http://gerrit.cloudera.org:8080/#/c/15990/4/testdata/datasets/functional/functional_schema_template.sql@2805 PS4, Line 2805: CREATE MATERIALIZED VIEW IF NOT EXISTS {db_name}{db_suffix}.{table_name} we should probably mention why this is necessary - I'm not sure if there is an Apache JIRA for this yet, if not can you file one? http://gerrit.cloudera.org:8080/#/c/15990/4/tests/query_test/test_compressed_formats.py File tests/query_test/test_compressed_formats.py: http://gerrit.cloudera.org:8080/#/c/15990/4/tests/query_test/test_compressed_formats.py@104 PS4, Line 104: dest_base_dir = '/{0}'.format(EXTERNAL_WAREHOUSE_DIR) I think we should fix this a different way. After discussing with Naveen, it seems like the expectation is that should actually be the MANAGED_WAREHOUSE_DIR. The fact that it is the EXTERNAL_WAREHOUSE_DIR is a bug in Hive, right? While this change will make this test pass for now, it will just start failing again when Hive makes the necessary bug fix. >From Joe: "Impala's test_compressed_formats() shouldn't depend on a Hive >generated location. That's not what we are testing. I think that >test_compressed_formats() can be modified to use a unique database, and then >we can specify the location when creating the table in Hive. That should >unblock Impala." -- To view, visit http://gerrit.cloudera.org:8080/15990 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57926babf4caebfd365e6be65a399f12ea68687f Gerrit-Change-Number: 15990 Gerrit-PatchSet: 4 Gerrit-Owner: Xiaomeng Zhang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Comment-Date: Fri, 29 May 2020 21:37:19 +0000 Gerrit-HasComments: Yes
