Xiaomeng Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15990 )
Change subject: IMPALA-9673: Add external warehouse dir variable in E2E test ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/15990/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15990/4//COMMIT_MSG@12 PS4, Line 12: HIVE-2299 > this isn't an external JIRA, so we can't reference it here. you probably wa Done http://gerrit.cloudera.org:8080/#/c/15990/4//COMMIT_MSG@18 PS4, Line 18: exhaustive tests. > this isn't a public Jenkins job. You can just say "Ran exhaustive tests" Done http://gerrit.cloudera.org:8080/#/c/15990/4/testdata/datasets/functional/functional_schema_template.sql File testdata/datasets/functional/functional_schema_template.sql: http://gerrit.cloudera.org:8080/#/c/15990/4/testdata/datasets/functional/functional_schema_template.sql@2805 PS4, Line 2805: CREATE MATERIALIZED VIEW IF NOT EXISTS {db_name}{db_suffix}.{table_name} > we should probably mention why this is necessary - I'm not sure if there is The command exists previously, I just moved to end of file, which has done by Joe in downstream. It has to be run after insert_only_transactional_table created. But it looks the sql command doesn't run in order, it didn't work if I put this sql in middle of file. So I have to put it in the end. http://gerrit.cloudera.org:8080/#/c/15990/4/tests/query_test/test_compressed_formats.py File tests/query_test/test_compressed_formats.py: http://gerrit.cloudera.org:8080/#/c/15990/4/tests/query_test/test_compressed_formats.py@104 PS4, Line 104: dest_base_dir = '/{0}'.format(EXTERNAL_WAREHOUSE_DIR) > I think we should fix this a different way. After discussing with Naveen, i Make sense. I'll update the patch. -- To view, visit http://gerrit.cloudera.org:8080/15990 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57926babf4caebfd365e6be65a399f12ea68687f Gerrit-Change-Number: 15990 Gerrit-PatchSet: 5 Gerrit-Owner: Xiaomeng Zhang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Xiaomeng Zhang <[email protected]> Gerrit-Comment-Date: Sun, 31 May 2020 16:52:49 +0000 Gerrit-HasComments: Yes
