Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15990 )
Change subject: IMPALA-9673: Add external warehouse dir variable in E2E test ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/15990/6/tests/query_test/test_compressed_formats.py File tests/query_test/test_compressed_formats.py: http://gerrit.cloudera.org:8080/#/c/15990/6/tests/query_test/test_compressed_formats.py@110 PS6, Line 110: hive_cmd = drop_cmd + 'CREATE TABLE %s LIKE %s LOCATION \'%s\';' % \ I think it makes more sense to make this a CREATE EXTERNAL TABLE since Hive is translating it an external table anyway, and the query is specifying a location. http://gerrit.cloudera.org:8080/#/c/15990/6/tests/query_test/test_compressed_formats.py@132 PS6, Line 132: self.run_stmt_in_hive(drop_cmd) we probably need a delete the dest_table_dir manually (using filesystem_client) after dropping the table, otherwise the data won't get cleaned up -- To view, visit http://gerrit.cloudera.org:8080/15990 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57926babf4caebfd365e6be65a399f12ea68687f Gerrit-Change-Number: 15990 Gerrit-PatchSet: 6 Gerrit-Owner: Xiaomeng Zhang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Xiaomeng Zhang <[email protected]> Gerrit-Comment-Date: Tue, 02 Jun 2020 21:19:55 +0000 Gerrit-HasComments: Yes
