Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15990 )
Change subject: IMPALA-9673: Add external warehouse dir variable in E2E test ...................................................................... Patch Set 5: (3 comments) mostly nits; patch almost looks good to me, pending the updates to tests/query_test/test_compressed_formats.py http://gerrit.cloudera.org:8080/#/c/15990/6/testdata/datasets/functional/functional_schema_template.sql File testdata/datasets/functional/functional_schema_template.sql: http://gerrit.cloudera.org:8080/#/c/15990/6/testdata/datasets/functional/functional_schema_template.sql@2313 PS6, Line 2313: nit whitespace http://gerrit.cloudera.org:8080/#/c/15990/6/testdata/datasets/functional/functional_schema_template.sql@2314 PS6, Line 2314: ---- BASE_TABLE_NAME would be good to mention that this is necessary because of a bug in Hive. http://gerrit.cloudera.org:8080/#/c/15990/6/testdata/workloads/functional-query/queries/QueryTest/create-database.test File testdata/workloads/functional-query/queries/QueryTest/create-database.test: http://gerrit.cloudera.org:8080/#/c/15990/6/testdata/workloads/functional-query/queries/QueryTest/create-database.test@60 PS6, Line 60: create database if not exists $DATABASE_cascade nit: line is too long -- To view, visit http://gerrit.cloudera.org:8080/15990 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57926babf4caebfd365e6be65a399f12ea68687f Gerrit-Change-Number: 15990 Gerrit-PatchSet: 5 Gerrit-Owner: Xiaomeng Zhang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Xiaomeng Zhang <[email protected]> Gerrit-Comment-Date: Tue, 02 Jun 2020 17:23:32 +0000 Gerrit-HasComments: Yes
