Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16208 )
Change subject: IMPALA-7655: Implement codegen for conditional functions (if, isnull, coalesce) ...................................................................... Patch Set 1: (3 comments) I'll wait for the tests and perf benchmarks but the code looks good. Thanks for picking this up. Hopefully we already have pretty good test coverage for these functions, but I haven't checked myself. http://gerrit.cloudera.org:8080/#/c/16208/1/be/src/exprs/conditional-functions.cc File be/src/exprs/conditional-functions.cc: http://gerrit.cloudera.org:8080/#/c/16208/1/be/src/exprs/conditional-functions.cc@20 PS1, Line 20: #include "exprs/conditional-functions.h" nit: convention is to put the corresponding header first in a separate block. http://gerrit.cloudera.org:8080/#/c/16208/1/be/src/exprs/conditional-functions.cc@21 PS1, Line 21: #include "runtime/runtime-state.h" Do we need these includes? http://gerrit.cloudera.org:8080/#/c/16208/1/be/src/exprs/conditional-functions.cc@84 PS1, Line 84: // TODO: Can we use non-const size arrays? Applies also to CaseExpr. It'd be best to use a std:: vector for unbounded variable-length arrays. This style of VLAs is not officially part of C++ and there is the risk of stack overflows at runtime. -- To view, visit http://gerrit.cloudera.org:8080/16208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11f617a9148492ccafb46112ce0af103a10090f8 Gerrit-Change-Number: 16208 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 16 Jul 2020 20:57:27 +0000 Gerrit-HasComments: Yes
